D9662: folderspanel context-menu option "Limit to Home Directory" should be always visible

[Michael Heidelbach]

michaelh added a comment.


  Even when you right-click home or a folder inside of it?
  I re-checked and it still works as expected here.

INLINE COMMENTS

> treeviewcontextmenu.cpp:130
>      const QUrl url = m_fileItem.url();
> -    const bool showLimitToHomeDirectory = url.isLocalFile() && (Dolphin::homeUrl().isParentOf(url) || (Dolphin::homeUrl() == url));
> -    if (showLimitToHomeDirectory) {
> -        QAction* limitFoldersPanelToHomeAction = new QAction(i18nc("@action:inmenu", "Limit to Home Directory"), this);
> -        limitFoldersPanelToHomeAction->setCheckable(true);
> -        limitFoldersPanelToHomeAction->setChecked(m_parent->limitFoldersPanelToHome());
> -        popup->addAction(limitFoldersPanelToHomeAction);
> -        connect(limitFoldersPanelToHomeAction, &QAction::toggled, this, &TreeViewContextMenu::setLimitFoldersPanelToHome);
> -    }
> +    const bool enableLimitToHomeDirectory = url.isLocalFile() && (Dolphin::homeUrl().isParentOf(url) || (Dolphin::homeUrl() == url));
> +    QAction* limitFoldersPanelToHomeAction = new QAction(i18nc("@action:inmenu", "Limit to Home Directory"), this);

I have also tested

  const bool enableLimitToHomeDirectory = url.isLocalFile();

It looks even more consistent to me. With one exception:
When

1. current url is outside home
2. 'Limit to  is unchecked

folderpanel stays as is when checking 'Limit to ...'. 
The option only becomes effective after navigating inside home.
May be we should jump to home in this case.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D9662

To: michaelh, #dolphin, emmanuelp, ngraham
Cc: elvisangelaccio, michaelh, spoorun, navarromorales, isidorov, firef, ngraham, andrebarros, alexeymin, genaxxx, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180113/62702f1a/attachment.htm>