D9836: Use BatchRenameJob to rename multiple files in Dolphin

Chinmoy Ranjan Pradhan noreply at phabricator.kde.org
Fri Jan 12 17:15:56 GMT 2018


chinmoyr marked 3 inline comments as done.
chinmoyr added inline comments.

INLINE COMMENTS

> broulik wrote in renamedialog.cpp:174
> Do we need `QUrl::StripTrailingSlash` here? At least most other places in KIO that use `RemoveFileName` set it

When undoing BatchRename parentUrl is not used. So IMO setting QUrl::StripTrailingSlash won't make any difference.  
I have set it just in case I am wrong.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D9836

To: chinmoyr, #dolphin
Cc: broulik
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180112/8b945777/attachment.htm>


More information about the kfm-devel mailing list