Review Request 129084: [KStandardItemListWidget] Don't paint overlay outside view for devicePixelRatio > 1

Kai Uwe Broulik kde at privat.broulik.de
Thu Jan 11 11:01:57 GMT 2018


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129084/
-----------------------------------------------------------

(Updated Jan. 11, 2018, 11:01 a.m.)


Status
------

This change has been marked as submitted.


Review request for Dolphin and David Edmundson.


Changes
-------

Submitted with commit bdcf12026d0d3e9dd0ac8e585d415bad0f274a7e by Kai Uwe Broulik to branch master.


Bugs: 369640
    https://bugs.kde.org/show_bug.cgi?id=369640


Repository: dolphin


Description
-------

Translate the position by devicePixelRatio


Diffs
-----

  src/kitemviews/kstandarditemlistwidget.cpp 8740cb7 


Diff: https://git.reviewboard.kde.org/r/129084/diff/1/


Testing
-------

I now get proper overlays by the git plugin again.

So, this was broken in both KIconLoader and here, and I expected Dolphin to just use the code in KIconLoader (Review 129083 fixes symbolic links but this one fixes overlayplugin stuff)


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180111/fefc7b15/attachment.htm>


More information about the kfm-devel mailing list