D9711: Fix renamed file reclaims focus

Andreas Krutzler noreply at phabricator.kde.org
Tue Jan 9 21:53:25 GMT 2018


akrutzler added a comment.


  In https://phabricator.kde.org/D9711#187679, @emateli wrote:
  
  > Unfortunately I do not have as much time as I would like to investigate this, however I suspect it may have to do with `slotRenamingFinished` and `forceUrlsSelection`. As in the slot is emitted after the files(s) have finished renaming but at that point the user has already changed the selection. If that's the case it may make a bit more sense to handle this inside the `forceUrlSelection` method instead.
  
  
  Hm I could not find a way to solve this inside the `forceUrlSelection` method. But maybe I am missing something.

INLINE COMMENTS

> elvisangelaccio wrote in dolphinview.cpp:1362
> I'm not 100% convinced. Why does the model return a wrong index? If I select b.tmp, here I'd expect the index for b.tmp, not the one for a.tmp

`m_currentItemUrl` is not set when a file is selected.  I tried to set it when the selection changes, but that does not work. Therefore, at this point, `m_currentItemUrl` stores the name of the file you just renamed.

REPOSITORY
  R318 Dolphin

BRANCH
  arcpatch-D9711

REVISION DETAIL
  https://phabricator.kde.org/D9711

To: akrutzler, ngraham, michaelh, #dolphin
Cc: emateli, elvisangelaccio, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180109/086e47e1/attachment.htm>


More information about the kfm-devel mailing list