D9610: Revive folderpanel when outside $HOME

[Elvis Angelaccio]

elvisangelaccio requested changes to this revision.
elvisangelaccio added a comment.
This revision now requires changes to proceed.


  Ah right, this is yet another regression from the Qt 5.10 fallout.
  
  In https://phabricator.kde.org/D9610#185157, @anthonyfieroni wrote:
  
  > @elvisangelaccio, the problem is file:/// + / + subdir result in invalid path. With @dfaure we make a patch in KIO <https://phabricator.kde.org/source/kio/browse/master/src/pathhelpers_p.h;de5cc8b6bb4c2b47e5be3cb580947a23b600de1e$29> does we should do it here?
  
  
  That's not exported, we cannot use it from Dolphin.

INLINE COMMENTS

> kfileitemmodel.cpp:651
>      for (int i = 0; i < subDirs.count() - 1; ++i) {
>          urlToExpand.setPath(urlToExpand.path() + '/' + subDirs.at(i));
>          m_urlsToExpand.insert(urlToExpand);

Here we need to append the slash only if the `path()` does not end with a slash already. This fixes the bug for me.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D9610

To: michaelh, #dolphin, elvisangelaccio
Cc: dfaure, elvisangelaccio, ngraham, anthonyfieroni, michaelh, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180103/440dc57f/attachment.htm>