D9610: Revive folderpanel when outside $HOME

Michael Heidelbach noreply at phabricator.kde.org
Tue Jan 2 19:14:32 GMT 2018


michaelh added a comment.




INLINE COMMENTS

> anthonyfieroni wrote in kfileitemmodel.cpp:651
> You can add check here.
> 
>   QString path = urlToExpand.path();
>   if (!path.endsWith(QLatin1Char('/')) {
>       path.append(QLatin1Char('/'));
>   }
>   urlToExpand.setPath(path() + subDirs.at(i));

At this point is there still a possibility that

  urlToExpand.path()

ends with a slash? Under what conditions?
I was wondering why the url is split with QDir::separator but joined again with '/'. 
And now it's QLatin1Char('/'). Why is that?

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D9610

To: michaelh, #dolphin
Cc: elvisangelaccio, ngraham, anthonyfieroni, michaelh, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180102/1b3d77a8/attachment.htm>


More information about the kfm-devel mailing list