D10804: Show "Empty Trash" button inside trash directory

[Mark Gaiser]

markg added a comment.


  In D10804#215803 <https://phabricator.kde.org/D10804#215803>, @rkflx wrote:
  
  > Maybe, but your code does not work all that reliably either. I think the best approach is to fix the bug, and then handle the trash state uniformly in Dolphin's existing code as well as your patch.
  >
  > @markg Any pointers to help fixing the bug?
  
  
  Well, i might.. But it's just a guess for now. To be sure i'd have to debug it as well to make more accurate assumptions.
  I almost seems like some signal (the completed signal i think) is not being emitted when an item is restored from the trash. You'd have to follow the code path of KCoreDirLister to see what happens when restoring an item and if it's supposed to emit that signal.
  
  So.. err, quite a bit of debugging is needed to fix it properly and to even figure out if the issue is in KIO or Dolphin (or both!).

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D10804

To: rominf, #dolphin, #kde_applications, ngraham, rkflx, markg
Cc: markg, emateli, broulik, elvisangelaccio, rkflx, mmustac, ngraham, #dolphin, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180228/eb7072e1/attachment.htm>