D10804: Show "Empty Trash" button inside trash directory

[Roman Inflianskas]

rominf added a comment.


  In D10804#215158 <https://phabricator.kde.org/D10804#215158>, @ngraham wrote:
  
  > In D10804#215153 <https://phabricator.kde.org/D10804#215153>, @rominf wrote:
  >
  > > The problem is that it's not reliable. Steps to reproduce bug:
  > >
  > > 1. Empty trash
  > > 2. Delete 1 item to trash
  > > 3. Restore that item by moving it outside of trash dir
  > > 4. Observe that trash is empty but an icon is red (e.g. trash is full)
  >
  >
  > See also https://bugs.kde.org/show_bug.cgi?id=252483
  
  
  Yes, exactly.
  
  > Sounds like we need to fix this bug first. Down the rabbit hole we go... as you can see, sometimes a few detours are required to fix other issues you encounter along the way! But in the end, everyone benefits, and it's really the only path to sane code and high-quality software.
  
  OK, I agree. Who is willing to fix that bug? :) I don't know this stuff good enough. David Faure wrote me on email:
  
  > If you need runtime notification of change for that value (e.g. to enable/disable a button), then you want to listen to KDirNotify I guess (and filter for trash: URLs, and then query isTrashEmpty again).
  
  May be this helps.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D10804

To: rominf, #dolphin, #kde_applications, ngraham, rkflx, markg
Cc: markg, emateli, broulik, elvisangelaccio, rkflx, mmustac, ngraham, #dolphin, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180227/9e7f8bba/attachment.htm>