D10804: Show "Empty Trash" button inside trash directory

[Roman Inflianskas]

rominf added a comment.


  In D10804#214941 <https://phabricator.kde.org/D10804#214941>, @rkflx wrote:
  
  > Thanks, much better than before, but still various problems:
  >
  > - Button only shown on one side for Split, while it should show on both sides. Reason: The URL bar is located in such a way so the user knows it will affect what is below, the button should work the same. Besides, this breaks as soon as the split is undone, i.e. no button at all anymore depending on which side you close.
  
  
  Fixed
  
  > - Middle-clicking to open trash in new tab does not show button.
  
  Fixed
  
  > - Opening Find hides the URL bar, it should hide the button too.
  
  Fixed
  
  > - After triggering the action, disable the button instead of hiding it.
  
  See comment below
  
  > - When the trash is empty initially, disable the button.
  
  See comment below
  
  > - When a file is moved to the trash, the button should be enabled dynamically instead of having to navigate back and forth.\
  
  See comment below
  
  > - We could think about disabling the raised button border with `setFlat(true)`, e.g. like in the toolbar or in the Find widget.
  
  Fixed
  
  The "comment below":
  We need a reliable signal that is emitted on trash emptiness changes to connect to. In `placesitem.cpp` there is an attempt to do this:
  
    m_trashDirLister = new KDirLister();
    m_trashDirLister->setAutoErrorHandlingEnabled(false, nullptr);
    m_trashDirLister->setDelayedMimeTypes(true);
    QObject::connect(m_trashDirLister.data(), static_cast<void(KDirLister::*)()>(&KDirLister::completed), m_signalHandler.data(), &PlacesItemSignalHandler::onTrashDirListerCompleted);
  
  The problem is that it's not reliable. Steps to reproduce bug:
  
  1. Empty trash
  2. Delete 1 item to trash
  3. Restore that item by moving it outside of trash dir
  4. Observe that trash is empty but an icon is red (e.g. trash is full)

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D10804

To: rominf, #dolphin, #kde_applications, ngraham, rkflx, markg
Cc: markg, emateli, broulik, elvisangelaccio, rkflx, mmustac, ngraham, #dolphin, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180227/ac19b5f6/attachment.htm>