D10804: Show "Empty trash" button inside trash directory

[Nathaniel Graham]

ngraham added a comment.


  In D10804#214244 <https://phabricator.kde.org/D10804#214244>, @rkflx wrote:
  
  > Interesting case, but I don't think we should show the button at all if you are in a subdirectory. It will affect the whole trash, not only parts of it. That's not what users expect, so we should not expose the button. Otherwise they might run into trouble.
  >
  > Deleting only parts of the trash is an expert feature, it can already be performed with a keyboard shortcut or the context menu. I think that's good enough.
  
  
  I wouldn't advocate hiding the button if you're in a trash sub-directory. We'd definitely get bug reports about that. Instead, we could just shorten/elide the visible URL/breadcrumb as necessary to make room for the Empty Trash button. In the screenshot in question, it's already elided anyway due to being too long, so this behavior wouldn't make anyone fly into a rage.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D10804

To: rominf, #dolphin, #kde_applications, ngraham
Cc: emateli, broulik, elvisangelaccio, rkflx, mmustac, ngraham, #dolphin, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180226/ce416edd/attachment.htm>