D10149: baloo-widgets: Add autotest for asychronously extracted data

[Michael Heidelbach]

michaelh marked 5 inline comments as done.
michaelh added inline comments.

INLINE COMMENTS

> elvisangelaccio wrote in filemetadataitemcounttest.cpp:77-87
> Actually I don't understand why there is a lambda here.
> 
> Imho we should test how many signals we emit (should be only 1, right?), and then check the number of items:
> 
>   QVERIFY(spy.wait());
>   QCOMPARE(spy.count(), 1);
>   QList<QWidget*> items = m_widget->findChildren<QWidget*>(QString(), Qt::FindDirectChildrenOnly);
>   QCOMPARE(items.count(), expectedItems * widgetsPerItem);

I don't either. Historical reasons, maybe?

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D10149

To: michaelh, #dolphin, elvisangelaccio
Cc: ngraham, ashaposhnikov, spoorun, nicolasfella, alexeymin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180225/8d012d40/attachment.htm>