D10804: Show "Empty trash" button inside trash directory

[Elvis Angelaccio]

elvisangelaccio added a comment.


  In D10804#213027 <https://phabricator.kde.org/D10804#213027>, @rominf wrote:
  
  > There is 3 places that is responsible for emptying trash. 2 of them use code from `trash/dolphintrash.cpp`. Third place is https://github.com/KDE/dolphin/blob/master/src/panels/places/placespanel.cpp#L458
  >
  > The code differs a little bit and I don't understand why. What should we do with that?
  
  
  The only difference I can see is the KNotification call. Which is broken anyway it seems, or at least I don't see any notification after emptying the trash.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D10804

To: rominf, #dolphin, #kde_applications, ngraham
Cc: elvisangelaccio, rkflx, mmustac, ngraham, #dolphin, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180225/e48a1cd5/attachment.htm>