D10834: filemetadatawidget: Use object names

[Elvis Angelaccio]

elvisangelaccio added inline comments.

INLINE COMMENTS

> filemetadatawidget.cpp:71
>      QStringList sortedKeys(const QVariantMap& data) const;
> +    QLabel* createLabel(const QString &key,  QString itemLabel, FileMetaDataWidget* parent);
>  

As I mentioned in the other review, QString objects are usually passed by const reference. I don't really see a reason to do it differently here.

> filemetadatawidget.cpp:117-118
> +{
> +    itemLabel.append(QLatin1Char(':'));
> +    QLabel* label = new QLabel(itemLabel, parent);
> +    label->setSizePolicy(QSizePolicy::MinimumExpanding, QSizePolicy::Preferred);

Could by simplified with `new QLabel(itemLabel + QLatin1Char(':'), parent)`, see comment above.

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D10834

To: michaelh, elvisangelaccio, #dolphin, #baloo
Cc: ashaposhnikov, spoorun, nicolasfella, alexeymin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180225/da5c696a/attachment.htm>