D10149: baloo-widgets: Add autotest for asychronously extracted data

Michael Heidelbach noreply at phabricator.kde.org
Sun Feb 25 12:33:55 GMT 2018


michaelh added a comment.


  In D10149#213263 <https://phabricator.kde.org/D10149#213263>, @elvisangelaccio wrote:
  
  > Tests now pass for me! But I agree that splitting this diff would be good.
  
  
  Ok, plenty of chances to mess with `arc` again. :-)

INLINE COMMENTS

> elvisangelaccio wrote in filemetadataitemcounttest.cpp:51
> I'm not sure there is a way to add escaped entries from the API. I think the users are supposed to manually write `$e` in their config files. But I could be wrong.

That comment is outdated. See comment in code.` .writePath() `does it correctly, but refuses to add empty entries. We should stick with` .writeEntry() `instead of `.writePath("/tmp")` or similar.

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D10149

To: michaelh, #dolphin, elvisangelaccio
Cc: ngraham, ashaposhnikov, spoorun, nicolasfella, alexeymin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180225/589f9d83/attachment.htm>


More information about the kfm-devel mailing list