D10804: Show "Empty trash" button inside trash directory

[Henrik Fehlauer]

rkflx added a comment.


  Thanks, having such a button in plain sight is a very sensible idea. Not sure about your custom bar yet, though, so here are two more ideas:
  
  - Show a `KMessageWidget` like Okular does for PDFs with forms. This would look a bit like the Nautilus screenshot in the bug. On the other hand it's not really a message.
  - Dynamically add a button to the toolbar. Konqueror used to do this for different KParts, it was a bit annoying when buttons jumped around. However I think it can be done:
    - Align Control button to the right (this would be good to have anyway!).
    - Now even in the default config there should be enough space to add Empty trash right after Split when visiting `trash:/`, without anything jumping around.
    - Set the button state to "disabled" once the trash has been emptied.
  
  My preference would be for the second option, but I'll leave it to the core Dolphin devs to decide on something and do the code review.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D10804

To: rominf, #dolphin, #kde_applications, ngraham
Cc: rkflx, mmustac, ngraham, #dolphin, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180225/ffe34014/attachment.htm>