D10804: Show "Empty trash" button inside trash directory

[Nathaniel Graham]

ngraham added a comment.


  No need for a space between `FEATURE` and the `:`
  
  Should be `FEATURE: 163306`

INLINE COMMENTS

> rominf wrote in dolphinviewcontainer.cpp:195
> It's C++ lambda function from C++11. Very handy for small tasks. Pros: don't pollute namespace with additional definitions, it takes less code.

I'll let the more experienced Dolphin developers weigh in here, but generally it's best to follow the existing coding style as long as there's nothing explicitly wrong with it, rather than being clever and saving code. Code is cheap!

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D10804

To: rominf, #dolphin, #kde_applications, ngraham
Cc: mmustac, ngraham, #dolphin, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180224/0ae44336/attachment.htm>