D10804: Show "Empty trash" button inside trash directory

Roman Inflianskas noreply at phabricator.kde.org
Sat Feb 24 23:06:22 GMT 2018


rominf added a comment.


  In D10804#213023 <https://phabricator.kde.org/D10804#213023>, @ngraham wrote:
  
  > 1. This is definitely better than not having it, but it needs some UI polish. How about:
  >   1. Make the "Empty Trash button smaller, somehow. Do we have a less tall button we can use for this?
  
  
  Why? In my opinion all buttons should be the same.

INLINE COMMENTS

> ngraham wrote in dolphinviewcontainer.cpp:195
> This syntax is a little unusual. Can you create a separate function that can be connected here rather than defining it inline?

It's C++ lambda function from C++11. Very handy for small tasks. Pros: don't pollute namespace with additional definitions, it takes less code.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D10804

To: rominf, #dolphin, #kde_applications, ngraham
Cc: mmustac, ngraham, #dolphin, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180224/224f01fc/attachment.htm>


More information about the kfm-devel mailing list