D10804: Show "Empty trash" button inside trash directory

[Nathaniel Graham]

ngraham added a comment.


  In D10804#213027 <https://phabricator.kde.org/D10804#213027>, @rominf wrote:
  
  > There is 3 places that is responsible for emptying trash. 2 of them use code from `trash/dolphintrash.cpp`. Third place is https://github.com/KDE/dolphin/blob/master/src/panels/places/placespanel.cpp#L458
  >
  > The code differs a little bit and I don't understand why. What should we do with that?
  
  
  We should seek to understand the differences, and if those differences aren't important or are accidental, we should unify them to all use the same `emptyTrash()` function.
  
  I'm sure some veteran Dolphin developers will be able to help us sort that out.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D10804

To: rominf, #dolphin, #kde_applications, ngraham
Cc: mmustac, ngraham, #dolphin, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180224/748e5c1a/attachment.htm>