D10804: Show "Empty trash" button inside trash directory

[Nathaniel Graham]

ngraham added a comment.


  Thanks for the patch! Couple of notes:
  
  1. All new files need the GPL text added at the top
  2. The Summary section needs at least one sentence before the `BUG:` keyword, and let's use `FEATURE` for this, instead of `BUG`. See https://community.kde.org/Infrastructure/Phabricator#Add_special_keywords
  3. For user-facing additions and improvements, please include a screenshot of how it looks with the patch. See https://community.kde.org/Infrastructure/Phabricator#Include_some_screenshots
  4. This is definitely better than not having it, but it needs some UI polish. How about:
    1. Move the "Empty Trash" button over to the right side of the window
    2. Make the "Empty Trash button smaller, somehow. Do we have a less tall button we can use for this?
    3. Get rid of the close button; there's no need for it.

INLINE COMMENTS

> dolphintrashwidget.cpp:22
> +    // Create empty trash button
> +    QPushButton *emptyTrashButton = new QPushButton(QIcon::fromTheme(QStringLiteral("user-trash")), "&Empty trash", this);
> +    emptyTrashButton->setFocus();

Use `-symbolic` versions of icons for buttons. This should be `user-trash-symbolic`, or else it will look like a folder in HiDPI mode.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D10804

To: rominf, #dolphin, #kde_applications
Cc: mmustac, ngraham, #dolphin, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180224/0c96dfb1/attachment.htm>