D10702: Always use a job to delete files to avoid freezing process waiting on IO
Jaime Torres Amate
noreply at phabricator.kde.org
Fri Feb 23 19:35:42 GMT 2018
jtamate requested changes to this revision.
jtamate added a comment.
This revision now requires changes to proceed.
My guess is that the problem is not in the direct delete of local files.
In fact, unlink() in most of the modern filesystems is not affected by the size of the file and is quite fast.
Another way to reproduce this bug:
- Create a directory
- Create 50.000 files of 2 bytes each one, for example with: "for i in `seq -w 1 50000`; do dd if=/dev/urandom of=file-$i.go bs=1 count=2; done"
- Go to that directory, select all files and shift-supr them.
- Confirm the dialog with the list of files to delete.
Wait too much for the task to start.
And after the notification of the work done, wait again for dolphin to become responsive.
The same problem affects the rename task in such directory,
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D10702
To: meven, #frameworks, dfaure, ngraham, #dolphin, jtamate
Cc: jtamate, markg, ngraham, #frameworks, michaelh
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180223/5096b912/attachment.htm>
More information about the kfm-devel
mailing list