D10609: Make "Split" checkable

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Thanks for the patch! Code,wise, you might also want to update `DolphinMainWindow::updateSplitAction()`, as it currently changes the text to "Close" when the split view is open. This doesn't happen for other checkable actions.
  
  Also, a few formatting changes are needed in the Summary section
  
  Put "BUG: 208023" on its own line, instead of "Fixes BUG #208023". See https://community.kde.org/Infrastructure/Phabricator#Formatting_your_patch
  
  Screenshots of the two states would be nice. In general, UI changes should include screenshots. Or even a screen recording! The more pizazz, the higher chance of being featured in the next Usability & Productivity status update <https://pointieststick.wordpress.com/category/usability-productivity/>!

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D10609

To: xyquadrat, #dolphin, ngraham
Cc: ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180217/0927983f/attachment.htm>