D10149: baloo-widgets: Add autotest for asychronously extracted data

[Michael Heidelbach]

michaelh added inline comments.

INLINE COMMENTS

> filemetadatawidget.cpp:162
> +        row.label = createLabel(itemLabel, q);
> +        row.label->setObjectName(QStringLiteral("L_%1").arg(key));
> +        const int spacerWidth = QFontMetrics(q->font()).size(Qt::TextSingleLine, " ").width();

Move to `createLabel()` to achieve one line:

  row.label = createLabel(key, m_provider->label(key), q);

> filemetadatawidget.cpp:168
> +        row.value = m_widgetFactory->createWidget(key, value, q);
> +        row.value->setObjectName(key);
> +        

Same as above: Let `m_widgetFactory->createWidget(key, value, q);` set object name
Not done yet, to avoid bloating this diff.

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D10149

To: michaelh, #dolphin, elvisangelaccio
Cc: ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180211/daa4580b/attachment.htm>