D10149: baloo-widgets: Add autotest for asychronously extracted data

[Michael Heidelbach]

michaelh marked an inline comment as done and an inline comment as not done.
michaelh added a comment.


  A change of diff title is in place now. I'd go for "filemetadatawidget: Make properties unique"

INLINE COMMENTS

> elvisangelaccio wrote in filemetadatawidgettest.cpp:118-132
> I think we should give a name to the widgets that we actually want to test (only 3 currently, right?), using `setObjectName()` on them in `filemetadatawidget.cpp`
> 
> This way we can just find them here with a simple `findChildren()`.

Done, but easier said than done :)

> filemetadatawidgettest.cpp:169
> +        // FIXME: Make this pass
> +        // QCOMPARE( map->value("Album Artist:"), QLatin1String("Bill Laswell"));
> +    };

Extracting those for many files might be a performance hit. OTOH the information is valuable.

> filemetadatawidgettest.cpp:188
> +        QEXPECT_FAIL("", "Intersecting Type data is not implemented", Continue);
> +        QVERIFY2(value, "Type data is missing");
> +        if (value) {

I think this should be done like in dolphin's properties dialogue. Leaving it for a different review.

> filemetadatawidgettest.cpp:202
> +            // Same for userComment
> +            QVERIFY(rating);
> +            QCOMPARE(rating->rating(), 0);

Hmm, the combining logic for comments and ratings differs from all other. Currently it can be destructive. OTOH is's very useful to rate/comment many files at once. Your opinion?

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D10149

To: michaelh, #dolphin, elvisangelaccio
Cc: ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180211/83427c8d/attachment.htm>