D10119: baloo-widgets: Create test to assert metaDataRequestFinished is emitted once only

Elvis Angelaccio noreply at phabricator.kde.org
Sat Feb 10 16:28:33 GMT 2018


elvisangelaccio added inline comments.

INLINE COMMENTS

> filemetadatawidgettest.cpp:88
> +}
> +#include "filemetadatawidgettest.moc"

Please remove the moc include. It is only needed when a `Q_OBJECT` class is declared in a .cpp file.

> elvisangelaccio wrote in filemetadatawidgettest.h:25
> Please move this include in the .cpp file

Not done, `#include "config.h"` should be in the .cpp file (since we only need it for the `TESTS_SAMPLE_FILES_PATH` macro).

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D10119

To: michaelh, elvisangelaccio, smithjd, vhanda, ngraham, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180210/e9fe4439/attachment.htm>


More information about the kfm-devel mailing list