D10119: baloo-widgets: Create test to assert metaDataRequestFinished is emitted once only

[Michael Heidelbach]

michaelh marked 5 inline comments as done.
michaelh added a comment.


  Thank you for your patience.

INLINE COMMENTS

> elvisangelaccio wrote in filemetadatawidgettest.cpp:38
> Not needed

********* Start testing of FileMetadataWidgetTest *********
  Config: Using QtTest library 5.10.0, Qt 5.10.0 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 7.3.0)
  PASS   : FileMetadataWidgetTest::initTestCase()
  QWARN  : FileMetadataWidgetTest::shouldSignalOnceWithoutFile() QSignalSpy: Unable to handle parameter 'items' of type 'KFileItemList' of method 'metaDataRequestFinished', use qRegisterMetaType to register it.

> elvisangelaccio wrote in filemetadatawidgettest.cpp:41-44
> empty function -> remove it
> 
> (`initTestCase()` and `cleanupTestCase()` definitions are not mandatory).

filemetadatawidgettest_autogen/EWIEGA46WW/moc_filemetadatawidgettest.cpp:97: undefined reference to `FileMetadataWidgetTest::cleanupTestCase()'
  collect2: error: ld returned 1 exit status

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D10119

To: michaelh, elvisangelaccio, smithjd, vhanda, ngraham, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180209/9bd937c4/attachment.htm>