D10119: baloo-widgets: Create test to assert metaDataRequestFinished is emitted once only

Michael Heidelbach noreply at phabricator.kde.org
Fri Feb 9 21:54:01 GMT 2018


michaelh marked 2 inline comments as done.
michaelh added inline comments.

INLINE COMMENTS

> elvisangelaccio wrote in filemetadatawidgettest.cpp:64
> Why are you expecting one element in `items()`? You are passing a list with no //valid local// urls to `setItems()`, so we don't append anything to `localItemsList`. Just replace the 1 with a 0 and the test will pass.

You're right. I didn't expect that but overlooked that line all the time, stupid.

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D10119

To: michaelh, elvisangelaccio, smithjd, vhanda, ngraham, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180209/80db5d0b/attachment.htm>


More information about the kfm-devel mailing list