D10267: [fileviewgitplugin] Add log action

[Anthony Fieroni]

anthonyfieroni added a comment.


  In https://phabricator.kde.org/D10267#203279, @elvisangelaccio wrote:
  
  > Is it normal that the dolphin process does not quit if I close the dolphin window but not the Git Log window?
  
  
  Yes, other plugin windows has a same behavior, they are parent-less since plugin isn't a widget.

INLINE COMMENTS

> elvisangelaccio wrote in fileviewgitplugin.cpp:433-435
> Why not using the new C++11 syntax:
> 
>   QStringList {QStringLiteral("foo"), QStringLiteral("bar"), ...}

It does not matter in that case, about me.

> elvisangelaccio wrote in fileviewgitplugin.cpp:458
> Hmm this should probably not be translated. If you are using git, you know what "git log" means ;)

I'll update to

  xi18nd("@action:intitle", "<application>Git</application> Log")

but should check if intitle presents :)

REPOSITORY
  R449 Plugins for Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D10267

To: anthonyfieroni, elvisangelaccio, emmanuelp, broulik, #dolphin
Cc: ngraham, ltoscano
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180208/c657e26a/attachment.htm>