D10267: [fileviewgitplugin] Add log action

[Elvis Angelaccio]

elvisangelaccio added a comment.


  Can you please rebase the patch? It doesn't apply currently

INLINE COMMENTS

> fileviewgitplugin.cpp:421
> +    const auto revision = link.toString();
> +    if (!revision.startsWith(QStringLiteral("rev:"))) {
> +        return;

`QLatin1Starting` here (because `startsWith()` has an overload for it).

> fileviewgitplugin.cpp:433-435
> +        QStringList() << QStringLiteral("log") << QStringLiteral("--relative=.") <<
> +        QStringLiteral("--date=format:%d-%m-%Y") << QStringLiteral("-n 100") <<
> +        QStringLiteral("--pretty=format:<tr> <td><a href=\"rev:%h\">%h</a></td> <td>%ad</td> <td>%s</td> <td>%an</td> </tr>")

Why not using the new C++11 syntax:

  QStringList {QStringLiteral("foo"), QStringLiteral("bar"), ...}

> fileviewgitplugin.cpp:458
> +    view->setAttribute(Qt::WA_DeleteOnClose);
> +    view->setWindowTitle(i18n("Git Log"));
> +    view->setOpenLinks(false);

Hmm this should probably not be translated. If you are using git, you know what "git log" means ;)

REPOSITORY
  R449 Plugins for Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D10267

To: anthonyfieroni, elvisangelaccio, emmanuelp, broulik, #dolphin
Cc: ngraham, ltoscano
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180208/392ab97f/attachment.htm>