D10119: baloo-widgets: Create test to assert metaDataRequestFinished is emitted once only

[Elvis Angelaccio]

elvisangelaccio added a comment.


  Patch doesn't apply here, can you update it?
  
    $ arc patch D10119
     INFO  Base commit is not in local repository; trying to fetch.
    Branch name arcpatch-D10119 already exists; trying a new name.
    Created and checked out branch arcpatch-D10119_1.
    Created and checked out branch arcpatch-D10143.
    Checking patch src/filemetadataprovider.cpp...
    Applied patch src/filemetadataprovider.cpp cleanly.
    
     Cherry Pick Failed!
     Exception 
    Command failed with error #1!
    COMMAND
    git cherry-pick 'arcpatch-D10143'
    
    STDOUT
    (empty)
    
    STDERR
    error: could not apply 4c0d4f8... baloo-widgets: Apply coding style to filemetadataprovider
    hint: after resolving the conflicts, mark the corrected paths
    hint: with 'git add <paths>' or 'git rm <paths>'
    hint: and commit the result with 'git commit'
    
    (Run with `--trace` for a full exception trace.)

INLINE COMMENTS

> filemetadatawidgettest.cpp:33
> +QTEST_MAIN(FileMetadataWidgetTest)
> +// Q_DECLARE_METATYPE(KFileItem)
> +Q_DECLARE_METATYPE(KFileItemList)

Please remove this commented line.

REPOSITORY
  R824 Baloo Widgets

BRANCH
  unittest (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10119

To: michaelh, elvisangelaccio, smithjd, vhanda, ngraham, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180203/501dd058/attachment.htm>