D10246: Toggle search and filter bar

[Henrik Fehlauer]

rkflx added a comment.


  In my book the keyboard shortcut behaviour is perfectly fine right now in Dolphin, and in line with Kate and Firefox: [Ctrl] + [F] will always open or focus the search bar, [Enter] will execute and move focus away, [⎋] will close (needs focus).
  
  Regarding the button: I guess toggling makes more sense. However, your patch is still off here: It only performs the toggling action, but the visual state does not indicate you have opened the search bar (like the Preview button does}.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D10246

To: mmustac, #dolphin
Cc: rkflx, broulik, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180203/cb816670/attachment.htm>