D10085: Faster drag&drop in directories with thousands of files

[Elvis Angelaccio]

elvisangelaccio requested changes to this revision.
elvisangelaccio added a comment.
This revision now requires changes to proceed.


  Looks better, but I spotted another regression: try to drop a folder on empty space in the view. Old code shows the drop menu with "Copy Here" and "Link Here", new code doesn't.

INLINE COMMENTS

> kitemlistcontroller.cpp:62
> +    m_keyboardAnchorPos(0),
> +    m_dropAccepted()
>  {

Not needed, default constructor is automatically called.

> kitemlistcontroller.cpp:940
> +    }
> +    event->setAccepted(m_dropAccepted[hoveredDir]);
>  

`m_dropAccepted` is a bit misleading as name for the member variable. Maybe `m_dropAcceptable` could work better.

> kitemlistcontroller.h:32
>  #include <QPointF>
> +#include <QCache>
>  class QTimer;

No longer necessary

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D10085

To: jtamate, #dolphin, elvisangelaccio, markg
Cc: markg, anthonyfieroni, michaelh, elvisangelaccio, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180203/62c2e3e7/attachment.htm>