D10267: [fileviewgitplugin] Add log action

Elvis Angelaccio noreply at phabricator.kde.org
Sat Feb 3 15:58:02 GMT 2018


elvisangelaccio requested changes to this revision.
elvisangelaccio added a comment.
This revision now requires changes to proceed.


  I like the idea, but please fix the dependency handling

INLINE COMMENTS

> CMakeLists.txt:15
>      Network
> +    WebEngineWidgets
>  )

Requiring WebEngine just for a git log plugin is too much. It should be an optional build-time dependency.

REPOSITORY
  R449 Plugins for Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D10267

To: anthonyfieroni, elvisangelaccio, emmanuelp, broulik, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180203/8d6d63c4/attachment.htm>


More information about the kfm-devel mailing list