D10085: Faster drag&drop in directories with thousands of files

[Mark Gaiser]

markg requested changes to this revision.
markg added a comment.
This revision now requires changes to proceed.


  Hi,
  
  I don't see why you use a QCache as you're not using any of it's features.
  If you want to maintain a mapping of QUrl -> bool, just use a QHash.
  I think maintaining a QUrl -> bool mapping is fine. What i did in my patch (only a bool) could have been an issue if you for whatever magical reason have a drag enter event with a different url without first receiving a drag close event - aka corner cases.
  
  Also, please drop the QtConcurrent part as that is not needed anymore.
  
  Are you also going to fix DragAndDropHelper::dropUrls? If not then i will take a look at that one. It should imho not call urlListMatchesUrl at all and only work if "event->isAccepted()" is true.

INLINE COMMENTS

> kitemlistcontroller.h:355
> +     */
> +    QCache<QUrl, QVariant> m_dropAccepted;
>  };

initialize this member in the class constructor initializer list.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D10085

To: jtamate, #dolphin, elvisangelaccio, markg
Cc: markg, anthonyfieroni, michaelh, elvisangelaccio, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180203/69c17c19/attachment.htm>