D10085: Faster drag&drop in directories with thousands of files

Anthony Fieroni noreply at phabricator.kde.org
Thu Feb 1 17:31:17 GMT 2018


anthonyfieroni added inline comments.

INLINE COMMENTS

> draganddrophelper.cpp:42-44
> +    if (&urls == lastUrls && &destUrl == lastDestUrl) {
> +        return lastResult;
> +    }

Don't do that. It's ridiculous, it cannot guarantied that function will be called with same objects. It's enough speed-up with concurrent calls.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D10085

To: jtamate, #dolphin, elvisangelaccio
Cc: anthonyfieroni, michaelh, elvisangelaccio, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180201/ea98dcda/attachment.htm>


More information about the kfm-devel mailing list