D17881: Fix title update when changing active split view

Elvis Angelaccio noreply at phabricator.kde.org
Sun Dec 30 23:37:25 GMT 2018


elvisangelaccio created this revision.
elvisangelaccio added a reviewer: Dolphin.
Herald added a project: Dolphin.
Herald added a subscriber: kfm-devel.
elvisangelaccio requested review of this revision.

REVISION SUMMARY
  The DolphinTabPage::activeViewUrlChanged signal triggers the title
  update in DolphinMainWindow, which sets the new title from the
  `m_activeViewContainer` instace.
  
  This means we need to notify the main window that the active view
  changed before telling it that the current url changed.
  
  BUG: 402641
  FIXED-IN: 18.12.1

REPOSITORY
  R318 Dolphin

BRANCH
  Applications/18.12

REVISION DETAIL
  https://phabricator.kde.org/D17881

AFFECTED FILES
  src/dolphintabpage.cpp
  src/tests/dolphinmainwindowtest.cpp

To: elvisangelaccio, #dolphin
Cc: kfm-devel, alexde, sourabhboss, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20181230/5deb8721/attachment.htm>


More information about the kfm-devel mailing list