D17617: Display error instead of silently failing when asked to create folder that already exists

Nathaniel Graham noreply at phabricator.kde.org
Mon Dec 17 14:58:05 GMT 2018


ngraham added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in knewfilemenu.cpp:916
> I still think it's better to emit errorMessage instead. Can you check it will be more difficult ?

I don't see how that makes sense. What's wrong with the current approach of expecting the jobs themselves to emit errors?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17617

To: ngraham, #dolphin, elvisangelaccio, dfaure
Cc: anthonyfieroni, dfaure, emateli, elvisangelaccio, Codezela, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20181217/bb8bb762/attachment.htm>


More information about the kfm-devel mailing list