D17635: After opening a new tab, focus the view if the URL navigator is in breadcrumbs mode

Nathaniel Graham noreply at phabricator.kde.org
Sun Dec 16 22:53:49 GMT 2018


ngraham created this revision.
ngraham added a reviewer: Dolphin.
Herald added a project: Dolphin.
Herald added a subscriber: kfm-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  When Dolphin opens a new tab and immediately switches to it, the URL navigator gets focus if it's editable. If it's not, the breadcrumbs bar gets keyboard focus, which is not very useful since it's not really intended for keyboard navigation.
  
  This patch changes that behavior so that when a new tab is opened and the URL navigator is in breadbrumbs mode, the view gets keyboard focus instead, which is more useful.
  
  BUG: 401899
  FIXED-IN: 18.12.1

TEST PLAN
  1. Put the URL navigator into breadcrumbs mode
  2. Open a new tab
  
  Observe that the view gets keyboard focus.

REPOSITORY
  R318 Dolphin

BRANCH
  focus-view-when-using-breadcrumbs (branched from Applications/18.12)

REVISION DETAIL
  https://phabricator.kde.org/D17635

AFFECTED FILES
  src/dolphintabwidget.cpp

To: ngraham, #dolphin
Cc: kfm-devel, alexde, sourabhboss, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20181216/403bec29/attachment.htm>


More information about the kfm-devel mailing list