D17550: Make the open url in tab feature a bit more discoverable

[Elvis Angelaccio]

elvisangelaccio added inline comments.

INLINE COMMENTS

> kurlnavigator.cpp:480
> +    if (q->receivers(SIGNAL(tabRequested(QUrl))) > 0) {
> +        for(auto button : qAsConst(m_navButtons)) {
> +            if (button->geometry().contains(p)) {

Space after `for`

> kurlnavigator.cpp:483
> +                const auto url = button->url();
> +                QAction* openInTab = popup->addAction(QIcon::fromTheme(QStringLiteral("tab-new")), i18n("Open %1 in tab", button->text()));
> +                q->connect(openInTab, &QAction::triggered, q, [this, url](){ Q_EMIT q->tabRequested(url); });

Do we really have to put the folder name in the extry text? This will make the popup menu very large if the folder name is long.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17550

To: apol, #dolphin, ngraham, #frameworks
Cc: elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20181216/8ab4b2b3/attachment.htm>