D17617: Display error instead of silently failing when asked to create folder that already exists
Elvis Angelaccio
noreply at phabricator.kde.org
Sun Dec 16 10:22:39 GMT 2018
elvisangelaccio requested changes to this revision.
elvisangelaccio added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> knewfilemenu.cpp:915
>
> + if (QDir (url.toLocalFile()).exists()) {
> + showCannotCreateFolderErrorDialog(name, i18n("A folder with this name already exists here."));
This breaks creation of non-local folders, because `QDir(QString())` always exists.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D17617
To: ngraham, #dolphin, elvisangelaccio
Cc: elvisangelaccio, Codezela, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20181216/617f1529/attachment.htm>
More information about the kfm-devel
mailing list