D17596: [KDirOperator] Allow renaming files from the context menu

[Dominik Haumann]

dhaumann added inline comments.

INLINE COMMENTS

> elvisangelaccio wrote in kdiroperator.cpp:907-909
> I think we should just use `dialog->open()` here. I see you've copied these 3 lines from Dolphin, but we should also fix it there (the rename dialog should really be modal).

Does dialog->open() block? If so, do we have to new the dialog at all? (Only reason I can think of is some DBus crash, see https://blogs.kde.org/2009/03/26/how-crash-almost-every-qtkde-application-and-how-fix-it-0 but that would require a better fix).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17596

To: ngraham, #frameworks, #dolphin
Cc: elvisangelaccio, markuss, dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20181215/2891c472/attachment.htm>