D17596: [KDirOperator] Allow renaming files from the context menu

Dominik Haumann noreply at phabricator.kde.org
Sat Dec 15 08:54:03 GMT 2018


dhaumann added a comment.


  Not sure about binary compatibility...

INLINE COMMENTS

> kdiroperator.h:774
> +     */
> +    virtual void renameSelected();
> +

Adding a virtual function changes the vtable, so this is BIC (binary incompatible). Does the function need to be virtual?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17596

To: ngraham, #frameworks, #dolphin
Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20181215/46a437db/attachment.htm>


More information about the kfm-devel mailing list