D17597: Use newly-upstreamed rename dialog from KIO

Nathaniel Graham noreply at phabricator.kde.org
Sat Dec 15 05:06:01 GMT 2018


ngraham created this revision.
ngraham added a reviewer: Dolphin.
Herald added a project: Dolphin.
Herald added a subscriber: kfm-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  With the rename dialog upstreamed in D17595 <https://phabricator.kde.org/D17595>, we can use it from there.
  
  This will require the KF5 dep to be bumped to 5.54, which should be feasible given that we're at the very beginning of a new Applications cycle.

TEST PLAN
  1. Dolphin Settings > uncheck "rename inline"
  2. Rename one or more files. Observe that it still works

REPOSITORY
  R318 Dolphin

BRANCH
  use-upstream-rename-dialog-from-kio (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17597

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/panels/folders/folderspanel.cpp
  src/views/dolphinview.cpp
  src/views/renamedialog.cpp
  src/views/renamedialog.h

To: ngraham, #dolphin
Cc: kfm-devel, alexde, sourabhboss, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20181215/fd460124/attachment.htm>


More information about the kfm-devel mailing list