D12162: Add support for touch scrolling in Dolphin

[Elvis Angelaccio]

elvisangelaccio requested changes to this revision.
elvisangelaccio added a comment.
This revision now requires changes to proceed.


  Finally had the time to look at this diff.
  
  The patch is surprisingly simpler than I was expecting, but still I'd recommend to split it into two parts:
  
  1. The code refactoring in `KItemListController` (i.e. `onPress()`, `onMove()`, etc.)
  2. The new support for QScroller and the touch events.

INLINE COMMENTS

> kitemlistcontroller.cpp:73
> +    m_touchDoubleClickTimer.setSingleShot(true);
> +    connect(&m_touchDoubleClickTimer, &QTimer::timeout, [this]() {
> +        m_touchDoubleClickInProgress = false;

Please add `this` as receiver, otherwise this connection can lead to crashes.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D12162

To: abalaji, #dolphin, ngraham, elvisangelaccio
Cc: elvisangelaccio, davidedmundson, acrouthamel, broulik, steffenh, kfm-devel, anthonyfieroni, ngraham, #dolphin, alexde, sourabhboss, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20181202/2033daaa/attachment.htm>