D16980: Return editable URL navigator to breadcrumb mode when it has focus and Ctrl+L is pressed

[Elvis Angelaccio]

elvisangelaccio added a comment.


  In D16980#361984 <https://phabricator.kde.org/D16980#361984>, @ngraham wrote:
  
  > Ctrl+L already does multiple things depending on the context:
  >
  > 1. URL navigator is a breadcrumb bar: Ctrl+L makes it editable, focuses it, and selects everything
  > 2. URL Navigator is editable but unfocused: Ctrl+L makes it focused and selects everything
  > 3. URL Navigator is editable and focused, but not everything is selected: Ctrl+L selects everything
  > 4. URL Navigator is editable and focused and everything is already selected: Ctrl+L does nothing
  >
  >   This patch currently changes 3 and 4 to be "Ctrl+L turns it back into a breadcrumb bar and returns focus to the main view". Perhaps I could tweak the patch so that this only happens for case #4, for which hitting Ctrl+L currently has no effect. Thoughts?
  
  
  That would be much better, since we wouldn't change behavior for those who rely on #3.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D16980

To: ngraham, #dolphin
Cc: elvisangelaccio, dhaumann, kfm-devel, alexde, sourabhboss, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20181202/e1e68312/attachment.htm>