D15071: Don't draw frames and shadows around images with transparency

[Anthony Fieroni]

anthonyfieroni added a comment.


  In D15071#315839 <https://phabricator.kde.org/D15071#315839>, @broulik wrote:
  
  > Why did the `ThumbCreator` frame flag get deprecated in the first place?
  
  
  https://git.reviewboard.kde.org/r/129921/ maybe because it's deprecated before thumbnail got fixed

INLINE COMMENTS

> kfilepreviewgenerator.cpp:945
>                              (maxSize.height() > KIconLoader::SizeSmallMedium) &&
> -                            !isIconCandidate;
> +                            !icon.hasAlpha();
>      if (!applyFrame) {

Maybe you should add case when it has an alpha but it's nulll.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15071

To: ngraham, #frameworks, #dolphin, #vdg, broulik, cfeck
Cc: anthonyfieroni, markg, abetts, bruns, kde-frameworks-devel, michaelh, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180827/970bfa98/attachment.htm>