D15069: Don't draw a frame around AppImage apps and images detected as likely to be icons

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Dolphin, broulik.
Herald added a project: Dolphin.
Herald added a subscriber: kfm-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  The file dialog in KIO already has logic to avoid drawing frames around images detected as likely to be icons. This patch brings that same feature to Dolphin. Also don't draw frames around AppImage apps, just like we don't draw frames around Windows executables.
  
  Since Dolphin doesn't use KIO for any of this (boo) we have to pull it over here too.
  
  BUG: 295526
  FIXED-IN: 18.12.0

TEST PLAN
  Icons no longer have frames:
  
  Non-icons still have frames:

REPOSITORY
  R318 Dolphin

BRANCH
  no-frame-around-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15069

AFFECTED FILES
  src/kitemviews/kfileitemmodelrolesupdater.cpp

To: ngraham, #dolphin, broulik
Cc: kfm-devel, spoorun, navarromorales, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180825/a36885df/attachment.htm>