D14814: Port away from kdelibs4support
Nathaniel Graham
noreply at phabricator.kde.org
Mon Aug 20 13:57:56 BST 2018
ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.
+1 conceptually. Everything looks good and works well, and all the tests pass. however I agree with @rkflx and would like to see the Show Tooltips checkbox removed when Baloo support has not been compiled in. No reason to show users features that are unavailable due to distro decisions.
REPOSITORY
R318 Dolphin
REVISION DETAIL
https://phabricator.kde.org/D14814
To: elvisangelaccio, #dolphin, broulik, ngraham, rkflx
Cc: rkflx, asturmlechner, kfm-devel, spoorun, navarromorales, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180820/a8c8bd51/attachment.htm>
More information about the kfm-devel
mailing list