D14378: Remove custom icon selection for trash

[Nathaniel Graham]

ngraham added a comment.


  In D14378#303387 <https://phabricator.kde.org/D14378#303387>, @pino wrote:
  
  > In D14378#303384 <https://phabricator.kde.org/D14378#303384>, @ngraham wrote:
  >
  > > In D14378#303383 <https://phabricator.kde.org/D14378#303383>, @pino wrote:
  > >
  > > > In D14378#303371 <https://phabricator.kde.org/D14378#303371>, @ngraham wrote:
  > > >
  > > > > Can you change your status to Accepted or else resign from the revision, then?
  > > >
  > > >
  > > > This does not make any sense to me. This looks already with the acks needed, doesn't it?
  > >
  > >
  > > The current status is "Needs Review" up at the top of the page because you're still marked as a "Request Changes". Phabricator doesn't mark it as accepted as long as there's anyone who's still requesting changes.
  >
  >
  > Then fix Phabricator, since my "Request changes" is not for the latest version (which has only acks), but for previous ones.
  
  
  I can't change Phabricator, but you can adapt to its quirks as we all have. It's just two clicks.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D14378

To: shubham, ngraham, #dolphin, broulik, pino, elvisangelaccio, cfeck
Cc: cfeck, elvisangelaccio, pino, kfm-devel, spoorun, navarromorales, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180804/be33ab5f/attachment.htm>