D14360: Remove custom icon selection for trash

[Shubham]

shubham added a comment.


  In D14360#302306 <https://phabricator.kde.org/D14360#302306>, @cfeck wrote:
  
  > I just noticed that this header says "const QString &icon() const;" i.e. we return a reference to a string. Assuming this API is really not public, it probably needs to be changed to a non-reference, correct?
  
  
  Yeah even @ngraham had said that it is actually a private header but not named so.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14360

To: shubham, ngraham, broulik, #dolphin, #frameworks, pino, dfaure, cfeck
Cc: dfaure, anthonyfieroni, cfeck, pino, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180802/e455aa6f/attachment.htm>