D14360: Remove custom icon selection for trash

Christoph Feck noreply at phabricator.kde.org
Thu Aug 2 14:38:29 BST 2018


cfeck added a comment.


  I just noticed that this header says "const QString &icon() const;" i.e. we return a reference to a string. Assuming this API is really not public, it probably needs to be changed to a non-reference, correct?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14360

To: shubham, ngraham, broulik, #dolphin, #frameworks, pino, dfaure, cfeck
Cc: dfaure, anthonyfieroni, cfeck, pino, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180802/7b689225/attachment.htm>


More information about the kfm-devel mailing list